From 83fd98a810f2ed95f1045da384442fc2fc33cc76 Mon Sep 17 00:00:00 2001 From: Laurent Bercot Date: Tue, 13 Jan 2026 04:47:24 +0000 Subject: Credit Josiah, remove extra parens --- AUTHORS | 1 + src/execline/backtick.c | 2 +- src/execline/withstdinas.c | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/AUTHORS b/AUTHORS index aa72e45..c2e18a9 100644 --- a/AUTHORS +++ b/AUTHORS @@ -14,6 +14,7 @@ Contributors: Eugen Wissner Paul Sopka Lennart Jablonka + Josiah Frentsos Thanks to: Dan J. Bernstein diff --git a/src/execline/backtick.c b/src/execline/backtick.c index 429e720..a954323 100644 --- a/src/execline/backtick.c +++ b/src/execline/backtick.c @@ -84,7 +84,7 @@ int main (int argc, char const **argv, char const *const *envp) else value.len = strlen(value.s) + 1 ; } else allgood = 1 ; - if ((!insist || allgood) && chomp && (value.len > 1) && (value.s[value.len - 2] == '\n')) + if ((!insist || allgood) && chomp && value.len > 1 && value.s[value.len - 2] == '\n') value.s[--value.len - 1] = 0 ; val1[uint_fmt(val1, wait_status(fdwstat))] = 0 ; el_modifs_and_exec(argv + argc1 + 1, var, val, insist < 2 ? 2 : 1, doimport) ; diff --git a/src/execline/withstdinas.c b/src/execline/withstdinas.c index 065f719..c516095 100644 --- a/src/execline/withstdinas.c +++ b/src/execline/withstdinas.c @@ -53,7 +53,7 @@ int main (int argc, char const *const *argv) strerr_warnw2x("stdin contained a null character", " - using default instead") ; } } - else if (chomp && (value.len > 1) && (value.s[value.len - 2] == '\n')) + else if (chomp && value.len > 1 && value.s[value.len - 2] == '\n') value.s[--value.len - 1] = 0 ; el_modif_and_exec(argv + 1, argv[0], val, doimport) ; } -- cgit v1.3.1