skalibs/src/libstddjb/alloc_realloc.c, branch v2.15.1.0The skarnet.org C programming libraryhttp://git.skarnet.org/cgit/skalibs/atom/src/libstddjb/alloc_realloc.c?h=v2.15.1.02024-01-18T22:26:42Z Do not free on failure to reallocate to size 0 (lol.)2024-01-18T22:26:42ZLaurent Bercotska-skaware@skarnet.org2024-01-18T22:26:42Zurn:sha1:83bcd1e5ed5eb5c4abc5154dae4dc6e133c8ddb4
Signed-off-by: Laurent Bercot <ska@appnovation.com>
Fix alloc_realloc UB2020-04-29T19:08:19ZLaurent Bercotska-skaware@skarnet.org2020-04-29T19:08:19Zurn:sha1:038082c425c40037a28111934dfb5037edbcad8c
void ** does not exist: the address of a generic pointer is not
properly defined (different pointer types may have different
representations). So, alloc_realloc cannot exist as is without UB.
Fortunately, it's not supposed to be used in the skalibs programming
style, and skalibs itself only uses it in two places
(stralloc_ready_tuned and stralloc_shrink) where the pointer is a
char *.
So we just fix the UB by making alloc_realloc() take a char **,
and it's only defined for that pointer type.
Nothing to see here folks, nothing happened at all.
We're down to ONE rogue sysdep, boys. ONE.2019-09-20T19:55:29ZLaurent Bercotska-skaware@skarnet.org2019-09-20T19:55:29Zurn:sha1:03f37879ef167dba6f5944716c06da81902e436e