From 038082c425c40037a28111934dfb5037edbcad8c Mon Sep 17 00:00:00 2001 From: Laurent Bercot Date: Wed, 29 Apr 2020 19:08:19 +0000 Subject: Fix alloc_realloc UB void ** does not exist: the address of a generic pointer is not properly defined (different pointer types may have different representations). So, alloc_realloc cannot exist as is without UB. Fortunately, it's not supposed to be used in the skalibs programming style, and skalibs itself only uses it in two places (stralloc_ready_tuned and stralloc_shrink) where the pointer is a char *. So we just fix the UB by making alloc_realloc() take a char **, and it's only defined for that pointer type. Nothing to see here folks, nothing happened at all. --- src/libstddjb/alloc_realloc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/libstddjb/alloc_realloc.c') diff --git a/src/libstddjb/alloc_realloc.c b/src/libstddjb/alloc_realloc.c index 8787291..82be92b 100644 --- a/src/libstddjb/alloc_realloc.c +++ b/src/libstddjb/alloc_realloc.c @@ -3,9 +3,9 @@ #include #include -int alloc_realloc (void **x, size_t n) +int alloc_realloc (char **x, size_t n) { - void *y = n ? realloc(*x, n) : (free(*x), alloc(0)) ; + char *y = n ? (char *)realloc(*x, n) : (free(*x), (char *)alloc(0)) ; if (!y) return 0 ; *x = y ; return 1 ; -- cgit v1.3.1