From 45923c08b00ccdfd888caf6d2b555a137c563988 Mon Sep 17 00:00:00 2001
From: Laurent Bercot <ska-skaware@skarnet.org>
Date: Wed, 18 Oct 2017 16:13:24 +0000
Subject:  Better packing / unpacking code

 Godbolted for x86_64 with gcc and clang.
---
 src/libstddjb/uint32_reverse.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

(limited to 'src/libstddjb/uint32_reverse.c')

diff --git a/src/libstddjb/uint32_reverse.c b/src/libstddjb/uint32_reverse.c
index 51c9877..2d3f915 100644
--- a/src/libstddjb/uint32_reverse.c
+++ b/src/libstddjb/uint32_reverse.c
@@ -1,17 +1,17 @@
 /* ISC license. */
 
+#include <stdint.h>
+#include <string.h>
 #include <skalibs/uint32.h>
 
 void uint32_reverse (char *s, size_t n)
 {
   while (n--)
   {
-    char c = s[0] ;
-    s[0] = s[3] ;
-    s[3] = c ;
-    c = s[1] ;
-    s[1] = s[2] ;
-    s[2] = c ;
-    s += 4 ;
+    uint32_t x ;
+    memcpy(&x, s, sizeof(uint32_t)) ;
+    x = uint32_bswap(x) ;
+    memcpy(s, &x, sizeof(uint32_t)) ;
+    s += sizeof(uint32_t) ;
   }
 }
-- 
cgit v1.3.1