Re: [PATCH] execline: use pathexec_or_die

From: Rasmus Villemoes <rv_at_rasmusvillemoes.dk>
Date: Thu, 18 May 2017 22:13:29 +0200

On Thu, May 18 2017, "Laurent Bercot" <ska-skaware_at_skarnet.org> wrote:

>>In exec.c, we already win a little by doing a single call of
>>pathexec_run instead of having each branch do their own
>
> This change is invalid. When you exit the if (dash) block, the
> dashed[] array goes out of scope, and is deallocated; but argv[0] is
> still pointing to it. The duplication of the call to pathexec_run()
> is necessary.
>

Right, sorry about that. Not a big fan of VLAs, maybe that's why I
misread the code.
Received on Thu May 18 2017 - 20:13:29 UTC