aboutsummaryrefslogtreecommitdiffstats
path: root/src/libnsss/nsss_switch_getgrent_r.c
diff options
context:
space:
mode:
authorLaurent Bercot <ska-skaware@skarnet.org>2021-09-09 19:58:12 +0000
committerLaurent Bercot <ska@appnovation.com>2021-09-09 19:58:12 +0000
commit6fdb4834cdb5557d9bd7562f61984da8bd0d9c80 (patch)
treec9ac0c6bc512beed2e550b9aba09eb2af090e6a7 /src/libnsss/nsss_switch_getgrent_r.c
parent1f213b642deb1d8e6139d2b7daac8f639c8717e7 (diff)
downloadnsss-6fdb4834cdb5557d9bd7562f61984da8bd0d9c80.tar.gz
Prepare for 0.2.0.0, lots of changes.
- Make _r functions completely thread-safe. - Save a lot of forking by having a persistent nsss_switch_query - Introduce a timeout to make the server expire - Start writing nsss-switch, not working yet. Signed-off-by: Laurent Bercot <ska@appnovation.com>
Diffstat (limited to 'src/libnsss/nsss_switch_getgrent_r.c')
-rw-r--r--src/libnsss/nsss_switch_getgrent_r.c17
1 files changed, 13 insertions, 4 deletions
diff --git a/src/libnsss/nsss_switch_getgrent_r.c b/src/libnsss/nsss_switch_getgrent_r.c
index 92a4264..f13445c 100644
--- a/src/libnsss/nsss_switch_getgrent_r.c
+++ b/src/libnsss/nsss_switch_getgrent_r.c
@@ -1,8 +1,11 @@
/* ISC license. */
#include <errno.h>
+#include <pthread.h>
+
#include <skalibs/stralloc.h>
#include <skalibs/genalloc.h>
+
#include <nsss/config.h>
#include <nsss/grp-switch.h>
#include <nsss/nsss-switch.h>
@@ -14,16 +17,18 @@ int nsss_switch_getgrent_r (struct group *gr, char *buf, size_t buflen, struct g
struct group gr2 ;
stralloc sa = STRALLOC_ZERO ;
genalloc ga = GENALLOC_ZERO ;
- int e ;
- if (!nsss_switch_start(&nsss_switch_here, NSSS_SWITCH_GRP, NSSS_NSSSD_PATH, 0, 0)) return errno ;
+ int e = pthread_mutex_lock(&nsss_switch_enumerator_mutex) ;
+ if (e) return e ;
+ if (!nsss_switch_start(&nsss_switch_enumerator, NSSS_SWITCH_GRP, NSSS_NSSSD_PATH, 0, 0)) return errno ;
e = errno ;
errno = 0 ;
- if (!nsss_switch_grp_get(&nsss_switch_here, &gr2, &sa, &ga, 0, 0))
+ if (!nsss_switch_grp_get(&nsss_switch_enumerator, &gr2, &sa, &ga, 0, 0))
{
*grp = 0 ;
if (!errno) errno = ENOENT ;
- return errno ;
+ goto err ;
}
+ pthread_mutex_unlock(&nsss_switch_enumerator_mutex) ;
if (!nsss_grp_copy(gr, buf, buflen, &gr2, sa.s, sa.len, genalloc_s(char *, &ga), genalloc_len(char *, &ga)))
{
genalloc_free(char *, &ga) ;
@@ -35,4 +40,8 @@ int nsss_switch_getgrent_r (struct group *gr, char *buf, size_t buflen, struct g
stralloc_free(&sa) ;
*grp = gr ;
return (errno = e, 0) ;
+
+ err:
+ pthread_mutex_unlock(&nsss_switch_enumerator_mutex) ;
+ return errno ;
}