Re: [PATCH] Fix openreadnclose failing if errno was nonzero before

From: Olivier Brunel <jjk_at_jjacky.com>
Date: Mon, 22 May 2017 09:17:52 +0200

On Mon, 22 May 2017 00:44:28 +0000
"Laurent Bercot" <ska-skaware_at_skarnet.org> wrote:

> Does this bug manifest in serious ways, for instance making a s6
> program
> fail when it should not? If it does, I'll need to release a new
> skalibs version just for this >.>

I didn't notice it from a s6 program, but from anopa where e.g.
aa-status would fail since it tries to read e.g. fd-notification
before calling s6_svstatus_read(), so when the file doesn't exist the
later call would fail.

I didn't notice issues w/ s6 programs, but as soon as I fixed this I
recompiled everything (execline, s6, etc) to avoid any issues, so I
didn't look further.
Received on Mon May 22 2017 - 07:17:52 UTC