False positive in skalibs system feature test

From: Shengjing Zhu <zhsj_at_debian.org>
Date: Wed, 23 Oct 2019 14:03:47 +0800

Hi,

With recent change of skalibs configure script, there's a false positive case.

`choose l` use linker to test function if exists. But actually I observe that,

```
/usr/bin/ld: src/librandom/random_string.lo: in function `random_string':
./src/librandom/random_string.c:26: warning: getrandom is not
implemented and will always fail
```

ld returns zero, even it knows "xxx is not implemented and will always fail".

I think the LDFLAGS should be appended with "-Wl,--fatal-warnings", so
that ld returns non-zero in such case.

I only observe such case on GNU Hurd/K*BSD actually. I'm thinking if
only these non-linux systems have such confused behaviour(why it links
successfully at all...)

-- 
Shengjing Zhu

Received on Wed Oct 23 2019 - 06:03:47 UTC