Re: [PATCH] Don't chmod device nodes for ! lines

From: Laurent Bercot <ska-skaware_at_skarnet.org>
Date: Thu, 06 Nov 2025 16:26:09 +0000

>Busybox mdev will not chmod the device node when the matched rule
>contains a '!'. Matching this behaviour makes it possible for a rule
>to preserve the mode set by the kernel for devices that are created
>automatically by devtmpfs.

  While reviewing it, I found that the same path where the chmod() occurs
also has the mknod() in it, so it needs to be guarded with
elem->movetype != MOVEINFO_NOCREATE anyway - so your patch is more than
a behaviour adjustment, it's a bugfix 🙂

  Applied, thanks!

--
  Laurent
Received on Thu Nov 06 2025 - 17:26:09 CET

This archive was generated by hypermail 2.4.0 : Thu Nov 06 2025 - 17:26:40 CET