Re: logpipe error handling patch

From: Gerrit Pape <>
Date: Tue, 29 Jul 2014 15:22:36 +0000

On Sat, Jul 26, 2014 at 10:44:18AM +0200, wrote:
> Hello, I wrote a patch for how broken filedescriptors when creating child
> are handled. Currently only the child dies, leaving non-working instance of
> runsv in place. My patch makes it kill the parent so the runsv process can
> be respawned properly when it gets to the state in which it can't produce
> working children.

Thanks for the patch, but it works around the bug and doesn't fix its
root cause. Laurent was correct when analysing this a few years ago,
thanks for that

Here's how to reproduce:
$ mkdir -p bug/log
$ cat <<EOT >bug/run && chmod 755 bug/run
exec sleep 14
$ cat <<EOT >bug/log/run && chmod 755 bug/log/run
exec sleep 47
$ runsv ./bug &
[1] 2016
$ sv x ./bug
$ sv u ./bug
runsv ./bug: fatal: unable to setup filedescriptor for ./run: file descriptor not open

runsv was told to exit, but does not do so until service and log service
have terminated. It sent TERM to the service, closed the pipe and so
standard input of the log service, and expects it to terminate now. If
the log service doesn't do so, and runsv is asked to startup the service
again, that it was previously told to take down and then exit, the bug
accurs as the pipe is no longer available.

Regards, Gerrit.
Received on Tue Jul 29 2014 - 15:22:36 UTC

This archive was generated by hypermail 2.3.0 : Sun May 09 2021 - 19:44:18 UTC