Re: [PATCH] Fix possible SIGSEGV on too many ftrigr listeners

From: Carlos Eduardo <carana2099_at_gmail.com>
Date: Sun, 5 May 2024 18:58:39 -0300

There's an extra & at line 53 (the one that free p->b.c.x).

Other than that, it works. Thanks! (and I really should go back to
reading the skalibs source code before asking for stuff that's already
in it :P)

Em dom., 5 de mai. de 2024 às 18:02, Laurent Bercot
<ska-skaware_at_skarnet.org> escreveu:
>
> >Maybe something like Zig's SegmentedList[1] would fit?
>
> Something like "stop trying to be too smart and just use malloc" fits
> perfectly ;)
> (I normally wouldn't do this, but the ftrigio structure already
> includes a ftrig1_t, a stralloc and a regex_t, all of which call
> malloc, so the trade-off is clearly in favor of aligning the behaviour
> of the ftrigio's buffer with everything else.)
>
> Fix pushed, can you please test that it works for you?
>
> --
> Laurent
>
Received on Sun May 05 2024 - 23:58:39 CEST

This archive was generated by hypermail 2.4.0 : Sun May 05 2024 - 23:59:21 CEST